-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-57334: Redact bearertoken in TestContext #29912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-57334: Redact bearertoken in TestContext #29912
Conversation
|
@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-57334, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-57334, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
e6487d2 to
a151bc4
Compare
|
/retest |
|
Verified that the token is redacted by testing locally |
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
Job Failure Risk Analysis for sha: a151bc4
|
|
@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-57334, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
a151bc4 to
b7e5fee
Compare
b7e5fee to
b238a93
Compare
|
Can't speak to the integration but the regarding the regex: /lgtm |
|
@bplaxco: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/lgtm |
|
/retest-required |
1f3d3ef to
2178917
Compare
|
/retest-required |
|
/test verify |
|
Job Failure Risk Analysis for sha: 2178917
|
|
/retest-required |
|
Job Failure Risk Analysis for sha: 2178917
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2178917
New tests seen in this PR at sha: 2178917
|
|
Job Failure Risk Analysis for sha: 2178917
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2178917
New tests seen in this PR at sha: 2178917
|
b979eca to
48c5254
Compare
|
@Shilpa-Gokul: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
48c5254 to
4010e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bplaxco, Shilpa-Gokul, smg247, tvardema The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified later @alokgoswami-ag |
|
@alokgoswami-ag: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Shilpa-Gokul: Jira Issue OCPBUGS-57334: All pull requests linked via external trackers have merged: This pull request has the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.19 |
|
@alokgoswami-ag: #29912 failed to apply on top of branch "release-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-4.20 |
|
@alokgoswami-ag: new pull request created: #30435 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Redact the new bearerToken printed as part of TestContext from CI runs